Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18820#discussion_r131570273
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameNaFunctionsSuite.scala ---
    @@ -261,5 +261,18 @@ class DataFrameNaFunctionsSuite extends QueryTest with 
SharedSQLContext {
         assert(out1(3).get(2).asInstanceOf[Double].isNaN)
         assert(out1(4) === Row("Amy", null, null))
         assert(out1(5) === Row(null, null, null))
    +
    +    // Replace with null
    +    val out2 = input.na.replace("name", Map(
    +      "Bob" -> "Bravo",
    +      "Alice" -> null
    --- End diff --
    
    Agree. Please try to improve the test case coverage. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to