Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18820#discussion_r131572498
  
    --- Diff: python/pyspark/sql/dataframe.py ---
    @@ -1393,6 +1393,16 @@ def replace(self, to_replace, value=None, 
subset=None):
             |null|  null| null|
             +----+------+-----+
     
    +        >>> df4.na.replace('Alice', None).show()
    --- End diff --
    
    I assume we removed `dataframe.replace` to promote use 
`dataframe.na.replace`? The doc says they are aliases anyway. I don't know but 
I tend to agree with paring doc tests and this looks removed in 
https://github.com/apache/spark/commit/ff26767c03cc76e7e86b238300367fa0d9b3e6a4.
    
    Let's leave this as is for now. I don't want to make this PR complicated.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to