Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/2432#discussion_r18315658
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1278,8 +1298,8 @@ class SparkContext(config: SparkConf) extends Logging
{
private def postApplicationStart() {
// Note: this code assumes that the task scheduler has been
initialized and has contacted
// the cluster manager to get an application ID (in case the cluster
manager provides one).
- listenerBus.post(SparkListenerApplicationStart(appName,
taskScheduler.applicationId(),
- startTime, sparkUser))
+ listenerBus.post(SparkListenerApplicationStart(appName,
+ Some(taskScheduler.applicationId().toString), startTime, sparkUser))
--- End diff --
It won't ever be null *in this code*. But it does not exist in application
event logs that *have already been created* by the current stable release, and
that the History Server needs to continue to be able to read and process
correctly.
I'm just saying that in those cases Spark seems to generally use Option
instead of null references. That's why I said that *in
SparkListenerApplicationStart*, it might be better to leave it as
`Option[String]` instead of having a potential null reference. But I'm ok with
having the null reference too, as long as the History Server is fixed to handle
that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
