Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18814#discussion_r131931843
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/expressions/WindowSpec.scala ---
    @@ -146,22 +146,22 @@ class WindowSpec private[sql](
       /**
        * Defines the frame boundaries, from `start` (inclusive) to `end` 
(inclusive).
        *
    -   * Both `start` and `end` are relative from the current row. For 
example, "0" means "current row",
    -   * while "-1" means one off before the current row, and "5" means the 
five off after the
    -   * current row.
    +   * Both `start` and `end` are relative from the current row. For 
example, "0" means
    +   * "current row", while "-1" means one off before the current row, and 
"5" means the five off
    +   * after the current row.
        *
        * We recommend users use `Window.unboundedPreceding`, 
`Window.unboundedFollowing`,
    -   * and `Window.currentRow` to specify special boundary values, rather 
than using integral
    -   * values directly.
    +   * and `Window.currentRow` to specify special boundary values, rather 
than using long values
    +   * directly.
        *
        * A range-based boundary is based on the actual value of the ORDER BY
        * expression(s). An offset is used to alter the value of the ORDER BY 
expression, for
        * instance if the current order by expression has a value of 10 and the 
lower bound offset
        * is -3, the resulting lower bound for the current row will be 10 - 3 = 
7. This however puts a
        * number of constraints on the ORDER BY expressions: there can be only 
one expression and this
    -   * expression must have a numerical data type. An exception can be made 
when the offset is 0,
    -   * because no value modification is needed, in this case multiple and 
non-numeric ORDER BY
    -   * expression are allowed.
    +   * expression must have a numerical data type. An exception can be made 
when the offset is
    +   * unbounded, because no value modification is needed, in this case 
multiple and non-literal
    --- End diff --
    
    ditto


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to