Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r132088495
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -1175,6 +1205,27 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
client.listFunctions(db, pattern)
}
+ /** Detect whether a table is stored with Hive-compatible metadata. */
+ private def isHiveCompatible(table: CatalogTable): Boolean = {
+ val provider =
table.provider.orElse(table.properties.get(DATASOURCE_PROVIDER))
+ if (provider.isDefined && provider != Some(DDLUtils.HIVE_PROVIDER)) {
+ table.properties.get(DATASOURCE_HIVE_COMPATIBLE) match {
+ case Some(value) =>
+ value.toBoolean
+ case _ =>
+ // If the property is not set, the table may have been created
by an old version
+ // of Spark. Detect Hive compatibility by comparing the table's
serde with the
+ // serde for the table's data source. If they match, the table
is Hive-compatible.
+ // If they don't, they're not, because of some other table
property that made it
+ // not initially Hive-compatible.
+ HiveSerDe.sourceToSerDe(provider.get) == table.storage.serde
--- End diff --
There is a change regarding treating case-sensitive DS tables as
Hive-incompatible. Once the given table is this kind of table without the new
`DATASOURCE_HIVE_COMPATIBLE` property, we should treat it as Hive compatible or
incompatible? Looks like for now we treat it as compatible?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
