Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/18849#discussion_r133133656
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
@@ -288,6 +303,7 @@ private[spark] class HiveExternalCatalog(conf:
SparkConf, hadoopConf: Configurat
// bucket specification to empty. Note that partition columns are
retained, so that we can
// call partition-related Hive API later.
def newSparkSQLSpecificMetastoreTable(): CatalogTable = {
+ val hiveCompatible = Map(DATASOURCE_HIVE_COMPATIBLE -> "false")
--- End diff --
This is a good idea if we do this from the first version. But now, for
backward compatibility, we have to handle the case without this special flag at
read path, then I can't see the point of having this flag.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
