Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18865#discussion_r132878430
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/json/JsonFileFormat.scala
 ---
    @@ -114,7 +114,16 @@ class JsonFileFormat extends TextBasedFileFormat with 
DataSourceRegister {
         }
     
         (file: PartitionedFile) => {
    -      val parser = new JacksonParser(actualSchema, parsedOptions)
    +      // SPARK-21610: when the `requiredSchema` only contains 
`_corrupt_record`,
    --- End diff --
    
    @viirya and @cloud-fan, How about adding few notes that implies 
`columnNameOfCorruptRecord` for both CSV and JSON is currently incomplete like 
union type in Hive for now?
    
    I can't think of a better way than parsing / converting everything always 
but I guess of course this is not what we want for now. I also am aware of few 
such issues about this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to