Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2432#discussion_r18370383
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -309,6 +306,27 @@ class SparkContext(config: SparkConf) extends Logging {
// constructor
taskScheduler.start()
+ private val appId = taskScheduler.applicationId()
+ conf.set("spark.app.id", appId)
+
+ val metricsSystem = env.metricsSystem
+ metricsSystem.registerSources()
+ metricsSystem.registerSinks()
+ metricsSystem.start()
--- End diff --
How about putting these three into `MetricsSystem#initialize()`, and add a
comment here explaining why the metrics system must be initialized after the
task scheduler (because it needs the ID).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
