Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2432#discussion_r18371551
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -72,7 +69,7 @@ private[spark] class EventLoggingListener(
* Return only the unique application directory without the base
directory.
*/
def getApplicationLogDir(): String = {
--- End diff --
And this should be renamed `logDirName` or something. I don't even know why
it's a function. It should just be a `val` (sorry, not your code, but could you
change it to avoid confusion?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
