Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/2432#discussion_r18371520
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/EventLoggingListener.scala ---
@@ -184,6 +181,11 @@ private[spark] object EventLoggingListener extends
Logging {
} else ""
}
+ def getLogDirName(logBaseDir: String, appId: String) = {
--- End diff --
This really is more of a "path" than a "name." We should call this
`getLogDirPath`. Can you also add a java doc for this with something like
"Return a file-system-safe path to the log directory for the given application."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
