Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/2432#issuecomment-57719110
Hey @sarutak this is looking much better. I left a few more comments. I
notice that a few of the scheduler backends still take in event logging
directory unnecessarily. We should revert the signatures there as I suggested
in the comments to simplify things. The rest, for the most part, are just code
style and java doc comments. Thanks for fixing this up.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
