Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/18971#discussion_r134550113
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/ReplayListenerSuite.scala ---
@@ -151,7 +153,10 @@ class ReplayListenerSuite extends SparkFunSuite with
BeforeAndAfter with LocalSp
* assumption that the event logging behavior is correct (tested in a
separate suite).
*/
private def testApplicationReplay(codecName: Option[String] = None) {
- val logDirPath = Utils.getFilePath(testDir, "test-replay")
+ val logDir = new File(testDir.getAbsolutePath, "test-replay")
+ // Here, it creates `Path` from the URI instead of the absolute path
for the explicit file
+ // scheme so that the string representation of this `Path` has leading
file scheme correctly.
+ val logDirPath = new Path(logDir.toURI)
--- End diff --
From your description it sounds like `Utils.resolveURI` might not be
correct for Windows paths. I don't have Windows available, so if you could try
these it might help in understanding:
Utils.resolveURI("C:\\WINDOWS")
Utils.resolveURI("/C:/WINDOWS")
Utils.resolveURI("C:/WINDOWS")
The first two should return the same thing ("file:/C:/WINDOWS" or something
along those lines) while the third I'm not sure, since it's ambiguous. But
that's probably the cause of the change of behavior.
Anyway the code change looks correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
