Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18887#discussion_r140692278
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
    @@ -720,75 +634,218 @@ private[history] class FsHistoryProvider(conf: 
SparkConf, clock: Clock)
           appId: String,
           attemptId: Option[String],
           prevFileSize: Long)(): Boolean = {
    -    lookup(appId, attemptId) match {
    -      case None =>
    -        logDebug(s"Application Attempt $appId/$attemptId not found")
    -        false
    -      case Some(latest) =>
    -        prevFileSize < latest.fileSize
    +    try {
    +      val attempt = getAttempt(appId, attemptId)
    +      val logPath = fs.makeQualified(new Path(logDir, attempt.logPath))
    +      recordedFileSize(logPath) > prevFileSize
    +    } catch {
    +      case _: NoSuchElementException => false
    --- End diff --
    
    Also issue the original log message?
    > logDebug(s"Application Attempt $appId/$attemptId not found")


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to