Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18887#discussion_r140699378
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
 ---
    @@ -624,7 +639,9 @@ class FsHistoryProviderSuite extends SparkFunSuite with 
BeforeAndAfter with Matc
       }
     
       private def createTestConf(): SparkConf = {
    -    new SparkConf().set("spark.history.fs.logDirectory", 
testDir.getAbsolutePath())
    +    new SparkConf()
    +      .set("spark.history.fs.logDirectory", testDir.getAbsolutePath())
    +      .set(LOCAL_STORE_DIR, Utils.createTempDir().getAbsolutePath())
    --- End diff --
    
    The test cases in `kvstore` are just unit test cases. We also need 
integration tests for ensuring they work as expected.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to