Github user steveloughran commented on a diff in the pull request:
https://github.com/apache/spark/pull/19487#discussion_r144545827
--- Diff:
core/src/main/scala/org/apache/spark/internal/io/HadoopMapReduceCommitProtocol.scala
---
@@ -60,15 +71,6 @@ class HadoopMapReduceCommitProtocol(jobId: String, path:
String)
*/
private def absPathStagingDir: Path = new Path(path, "_temporary-" +
jobId)
--- End diff --
what if path is null here when passed in? I'd actually expect an
IllegalArgumentException being raised, at least from looking at
Path.checkParthArg()
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
