Github user mridulm commented on the issue:

    https://github.com/apache/spark/pull/19487
  
    I will change from `test:` to `::invalid::` to explicitly indicate an 
invalid path (I picked the first path which gave me a parse error :) ).
    
    On the question of whether `path` constructor param can be invalid - my 
understanding @steveloughran was that `mapred.output.dir` conf could be set to 
any arbitrary string for non path based committers, and it is for the output 
format and committer to handle it suitably ?
    That is, it need be a valid `Path` and could be encoding some other info ? 
Hence why I added invalid path handling case - so that we dont keep fighting 
this `IllegalArgumentException` due to assuming it is a valid path case.
    
    If this understanding is incorrect, I agree with @HyukjinKwon and I will 
need to make it support only `null` and `""`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to