Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19272#discussion_r149237172
  
    --- Diff: 
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
 ---
    @@ -772,6 +783,14 @@ private[spark] class 
MesosCoarseGrainedSchedulerBackend(
           offer.getHostname
         }
       }
    +
    +  override def initializeHadoopDelegationTokens(): Option[Array[Byte]] = {
    +    if (UserGroupInformation.isSecurityEnabled) {
    +      Some(hadoopCredentialRenewer.tokens)
    --- End diff --
    
    So, seems to me that your "renewer" is doing more than just renewing 
tokens; it's also being used to generate the initial set. So aside from my 
comments about initializing the renewer here, you should also probably make 
this API a little cleaner. Right now there's too much coupling.
    
    The renewer should to renewals only, otherwise it should be called 
something different.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to