Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19272#discussion_r149235352
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
    @@ -99,11 +96,8 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, val rpcEnv: Rp
       // The num of current max ExecutorId used to re-register appMaster
       @volatile protected var currentExecutorIdCounter = 0
     
    -  // hadoop token manager used by some sub-classes (e.g. Mesos)
    -  def hadoopDelegationTokenManager: Option[HadoopDelegationTokenManager] = 
None
    -
    -  // Hadoop delegation tokens to be sent to the executors.
    -  val hadoopDelegationCreds: Option[Array[Byte]] = 
getHadoopDelegationCreds()
    +  // Hadoop delegation tokens to be sent to the executors, can be updated 
as necessary.
    +  protected var hadoopDelegationTokens: Option[Array[Byte]] = 
initializeHadoopDelegationTokens()
    --- End diff --
    
    Why is this protected? There's no reason I can see for subclasses to need 
access to this field.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to