Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/19525#discussion_r149533876
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -2769,6 +2769,20 @@ class LogisticRegressionSuite
LogisticRegressionSuite.allParamSettings, checkModelData)
}
+ test("read/write with BoundsOnCoefficients") {
+ def checkModelData(model: LogisticRegressionModel, model2:
LogisticRegressionModel): Unit = {
+ assert(model.getLowerBoundsOnCoefficients ===
model2.getLowerBoundsOnCoefficients)
+ assert(model.getUpperBoundsOnCoefficients ===
model2.getUpperBoundsOnCoefficients)
--- End diff --
In ```checkModelData```, we should check model itself like
```coefficients``` and ```intercept```. We already have check equality for all
params including ```lowerBoundsOnCoefficients``` inside of
```testEstimatorAndModelReadWrite```.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
