Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19525#discussion_r149522660
  
    --- Diff: 
mllib-local/src/main/scala/org/apache/spark/ml/linalg/Matrices.scala ---
    @@ -476,6 +476,10 @@ class DenseMatrix @Since("2.0.0") (
     @Since("2.0.0")
     object DenseMatrix {
     
    +  @Since("2.3.0")
    +  private[ml] def unapply(dm: DenseMatrix): Option[(Int, Int, 
Array[Double], Boolean)] =
    --- End diff --
    
    If this is a public API, we should remove ```private[ml]```.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to