Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19813#discussion_r156238152
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
 ---
    @@ -61,7 +61,11 @@ case class BoundReference(ordinal: Int, dataType: 
DataType, nullable: Boolean)
       override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = {
         if (ctx.currentVars != null && ctx.currentVars(ordinal) != null) {
           val oev = ctx.currentVars(ordinal)
    -      ev.isNull = oev.isNull
    +      if (nullable) {
    --- End diff --
    
    oh, right.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to