Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/19813#discussion_r156285866
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -979,7 +1016,11 @@ class CodegenContext {
val expr = e.head
// Generate the code for this expression tree.
val eval = expr.genCode(this)
- val state = SubExprEliminationState(eval.isNull, eval.value)
+ val state = if (expr.nullable) {
--- End diff --
Yea, can remove it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
