Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19813#discussion_r156284378
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Expression.scala
 ---
    @@ -105,6 +105,12 @@ abstract class Expression extends TreeNode[Expression] 
{
           val isNull = ctx.freshName("isNull")
           val value = ctx.freshName("value")
           val eval = doGenCode(ctx, ExprCode("", isNull, value))
    +      eval.isNull = if (this.nullable) eval.isNull else "false"
    --- End diff --
    
    at least we should do it in a new PR. do you wanna do it after this one get 
merge?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to