Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19954#discussion_r157893177
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodFactory.scala
---
@@ -209,9 +213,33 @@ private[spark] class ExecutorPodFactoryImpl(sparkConf:
SparkConf)
.build()
}.getOrElse(executorContainer)
- new PodBuilder(executorPod)
+ val (maybeSecretsMountedPod, maybeSecretsMountedContainer) =
+ mountSecretsBootstrap.map { bootstrap =>
+ bootstrap.mountSecrets(executorPod, containerWithLimitCores)
--- End diff --
So this is where my suggestion of getting rid of bootstraps and using
inheritance breaks. For that to work, this code would have to use the same
abstraction as the driver side (orchestrator + steps), but it doesn't.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
