Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/19954#discussion_r157899398
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/DriverInitContainerBootstrapStep.scala
---
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.deploy.k8s.submit.steps
+
+import java.io.StringWriter
+import java.util.Properties
+
+import io.fabric8.kubernetes.api.model.{ConfigMap, ConfigMapBuilder,
ContainerBuilder, HasMetadata}
+
+import org.apache.spark.deploy.k8s.Config._
+import org.apache.spark.deploy.k8s.submit.{InitContainerUtil,
KubernetesDriverSpec}
+import
org.apache.spark.deploy.k8s.submit.steps.initcontainer.{InitContainerConfigurationStep,
InitContainerSpec}
+
+/**
+ * Configures the driver init-container that localizes remote dependencies
into the driver pod.
+ * It applies the given InitContainerConfigurationSteps in the given order
to produce a final
+ * InitContainerSpec that is then used to configure the driver pod with
the init-container attached.
+ * It also builds a ConfigMap that will be mounted into the
init-container. The ConfigMap carries
+ * configuration properties for the init-container.
+ */
+private[spark] class DriverInitContainerBootstrapStep(
+ steps: Seq[InitContainerConfigurationStep],
--- End diff --
I don't think we want to be using a separate step hierarchy here.
Originally we weren't sure how many different configurations the init-container
could have. But now that we've had the init-container around for awhile we've
only seen two variations: submitting local files vs. not submitting local
files. I think we can inline these configurations into the step directly.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
