Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/19954#discussion_r157891637
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/rest/k8s/SparkConfPropertiesParser.scala
 ---
    @@ -0,0 +1,50 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.spark.deploy.rest.k8s
    +
    +import java.io.{File, FileInputStream}
    +import java.util.Properties
    +
    +import scala.collection.JavaConverters._
    +
    +import com.google.common.collect.Maps
    +
    +import org.apache.spark.SparkConf
    +import org.apache.spark.internal.config.{ConfigReader, SparkConfigProvider}
    +import org.apache.spark.util.Utils
    +
    +private[spark] object SparkConfPropertiesParser {
    +
    +  def getSparkConfFromPropertiesFile(propertiesFile: File): SparkConf = {
    +    val sparkConf = new SparkConf(true)
    +
    +    if (!propertiesFile.isFile) {
    +      throw new IllegalArgumentException("Server properties file given at 
" +
    +        s"${propertiesFile.getAbsoluteFile} does not exist or is not a 
file.")
    +    }
    +
    +    val properties = new Properties
    --- End diff --
    
    There's probably already a method or a combination of calls in the `Utils` 
class that does what you want. e.g. `loadDefaultSparkProperties` or 
`getPropertiesFromFile` or some other.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to