Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19591#discussion_r158355602
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/LauncherServer.java ---
@@ -210,8 +209,13 @@ int getPort() {
* Removes the client handle from the pending list (in case it's still
there), and unrefs
* the server.
*/
- void unregister(ChildProcAppHandle handle) {
- pending.remove(handle.getSecret());
+ void unregister(AbstractAppHandle handle) {
+ for (Map.Entry<String, AbstractAppHandle> e : pending.entrySet()) {
--- End diff --
I think I had something like that at some point, but it was more code than
the current version... there's a little bit of a chicken & egg problem between
handles and secrets, and keeping them separate simplified things a bit at least
for me.
I'll do the rename.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
