Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19591#discussion_r158537984
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/InProcessAppHandle.java ---
@@ -0,0 +1,74 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.launcher;
+
+import java.io.IOException;
+import java.lang.reflect.Method;
+import java.util.concurrent.ThreadFactory;
+import java.util.logging.Level;
+import java.util.logging.Logger;
+
+class InProcessAppHandle extends AbstractAppHandle {
+
+ private static final Logger LOG =
Logger.getLogger(ChildProcAppHandle.class.getName());
+ private static final ThreadFactory THREAD_FACTORY = new
NamedThreadFactory("spark-app-%d");
+
+ private Thread app;
+
+ InProcessAppHandle(LauncherServer server) {
+ super(server);
+ }
+
+ @Override
+ public synchronized void kill() {
+ LOG.warning("kill() may leave the underlying app running in in-process
mode.");
+ disconnect();
+
+ // Interrupt the thread. This is not guaranteed to kill the app,
though.
--- End diff --
`SparkSubmit` just runs some other class, in this case, the class that
submits the app in cluster mode (or the user class in client mode). And that
class could swallow these interrupts, just as `SparkSubmit` also could (but
doesn't?).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
