Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r160501177
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala ---
@@ -17,4 +17,22 @@
package org.apache.spark.sql.test
-trait SharedSQLContext extends SQLTestUtils with SharedSparkSession
+trait SharedSQLContext extends SQLTestUtils with SharedSparkSession {
+
+ /**
+ * Auto thread audit is turned off here intentionally and done manually.
--- End diff --
I'm not sure I understand your explanation, and I definitely don't
understand what's going on from the comment in the code. What I'm asking is for
the comment here to explain not what the code is doing, but *why* it's doing it.
Basically, if instead of the code you have here, you just called
`super.beforeAll` and `super.afterAll`, without disabling
`enableAutoThreadAudit`, what will break and why? That's what the comment
should explain.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
