Github user gaborgsomogyi commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r161370006
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala ---
@@ -17,4 +17,37 @@
package org.apache.spark.sql.test
-trait SharedSQLContext extends SQLTestUtils with SharedSparkSession
+trait SharedSQLContext extends SQLTestUtils with SharedSparkSession {
+
+ /**
+ * Suites extending [[SharedSQLContext]] are sharing resources (eg.
SparkSession) in their tests.
+ * Such resources are initialized by the suite before thread audit takes
thread snapshot and
--- End diff --
Much better phrased and compressed explanation, applied. Agree that it
would be better to move this functionality into `SharedSparkSession` on the
other hand it would lead far in terms of number of modifications.
`SharedSparkSession` has to extend has to extend `SparkFunSuite` which I don't
see it worth the effort. The other option what I see also doesn't help in terms
of understanding. Namely moving manual thread audit into `SparkFunSuite` and
leaving `enableAutoThreadAudit = false` in `SharedSQLContext` but splitting
functionality rarely can help. Ideas?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
