Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/19893#discussion_r161317670
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SharedSQLContext.scala ---
@@ -17,4 +17,37 @@
package org.apache.spark.sql.test
-trait SharedSQLContext extends SQLTestUtils with SharedSparkSession
+trait SharedSQLContext extends SQLTestUtils with SharedSparkSession {
+
+ /**
+ * Suites extending [[SharedSQLContext]] are sharing resources (eg.
SparkSession) in their tests.
+ * Such resources are initialized by the suite before thread audit takes
thread snapshot and
--- End diff --
Why is the latter a problem? At worst you'll have less thread after the
suite finishes than when it started, which should be fine, no? The problem is
having leaked threads, not the other way around.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
