Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/20580#discussion_r167482592
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/execution/vectorized/WritableColumnVector.java
---
@@ -691,11 +696,6 @@ public WritableColumnVector arrayData() {
*/
protected abstract WritableColumnVector reserveNewColumn(int capacity,
DataType type);
- protected boolean isArray() {
- return type instanceof ArrayType || type instanceof BinaryType || type
instanceof StringType ||
--- End diff --
`WritableColumnVector` class will be public API in Spark 2.3. It seem to be
necessary to discuss with @cloud-fan for changing the visibility of a method or
field.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
