Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20647#discussion_r170160050
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/MicroBatchExecution.scala
 ---
    @@ -77,31 +79,32 @@ class MicroBatchExecution(
           
sparkSession.sqlContext.conf.disabledV2StreamingMicroBatchReaders.split(",")
     
         val _logicalPlan = analyzedPlan.transform {
    -      case streamingRelation@StreamingRelation(dataSourceV1, sourceName, 
output) =>
    -        toExecutionRelationMap.getOrElseUpdate(streamingRelation, {
    +      case s @ StreamingRelation(dsV1, sourceName, output) =>
    --- End diff --
    
    This is to make the naming consistent, see 
https://github.com/apache/spark/pull/20647/files#diff-c2959c723f334c32806217216014362eL89
    
    In general we don't forbid users to fix some code style issue in related 
PRs, otherwise we need to have code-style-fix-only PRs, which is not the common 
case.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to