Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20647#discussion_r170303937
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
 ---
    @@ -107,17 +106,24 @@ case class DataSourceV2Relation(
     }
     
     /**
    - * A specialization of DataSourceV2Relation with the streaming bit set to 
true. Otherwise identical
    - * to the non-streaming relation.
    + * A specialization of [[DataSourceV2Relation]] with the streaming bit set 
to true.
    + *
    + * Note that, this plan has a mutable reader, so Spark won't apply 
operator push-down for this plan,
    --- End diff --
    
    No, I think it is okay, but I would not add it if it were my commit. It is 
unlikely that this will cause commit conflicts so it should be fine. I would 
just prefer to have a docs commit later to keep track of this.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to