Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/20647#discussion_r170307903
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
---
@@ -23,11 +23,11 @@ import org.apache.spark.sql.execution.SparkPlan
object DataSourceV2Strategy extends Strategy {
override def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
- case relation: DataSourceV2Relation =>
- DataSourceV2ScanExec(relation.output, relation.reader) :: Nil
+ case r: DataSourceV2Relation =>
--- End diff --
Strictly speaking, if I don't change this line, then I need to split the
next line into 2 lines, as I need to pass more parameters, so it's still a
2-line diff.
I think tiny things like this is really not worth to be pointed during code
review, we should save our effort to focus more on the actual code logic. What
do you think?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
