Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20744#discussion_r174034001
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
@@ -150,14 +150,18 @@ class HistoryServer(
ui: SparkUI,
completed: Boolean) {
assert(serverInfo.isDefined, "HistoryServer must be bound before
attaching SparkUIs")
- ui.getHandlers.foreach(attachHandler)
+ handlers.synchronized {
+ ui.getHandlers.foreach(attachHandler)
+ }
addFilters(ui.getHandlers, conf)
--- End diff --
shall we also keep `handlers` synchronized for this line?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
