Github user zhouyejoe commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20744#discussion_r173981826
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala ---
    @@ -148,14 +148,17 @@ class HistoryServer(
           appId: String,
           attemptId: Option[String],
           ui: SparkUI,
    -      completed: Boolean) {
    +      completed: Boolean): Unit = this.synchronized {
    --- End diff --
    
    In order to fine grain the synchronization, can we add synchronize on 
handlers only?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to