Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20327#discussion_r173030160
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
    @@ -342,13 +342,13 @@ private[spark] object JettyUtils extends Logging {
               -1,
               -1,
               connectionFactories: _*)
    +        connector.setHost(hostName)
             connector.setPort(port)
             connector.start()
     
             // Currently we only use "SelectChannelConnector"
             // Limit the max acceptor number to 8 so that we don't waste a lot 
of threads
             connector.setAcceptQueueSize(math.min(connector.getAcceptors, 8))
    --- End diff --
    
    Show this also be moved before the `start()` call? (Unrelated to your 
change, but since you're here...)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to