Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20327#discussion_r173031021
  
    --- Diff: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
 ---
    @@ -68,6 +69,20 @@ private[spark] class ApplicationMaster(args: 
ApplicationMasterArguments) extends
     
       private val securityMgr = new SecurityManager(sparkConf)
     
    +  private val yarnConf = new 
YarnConfiguration(SparkHadoopUtil.newConfiguration(sparkConf))
    +
    +  if (isClusterMode) {
    +    // If the public address of NM does not adhere 
Utils.localCanonicalHostname
    +    // there is no way to correctly configure it from the client. To this 
end,
    +    // this logic replicates the way NM determines the address to bind 
listeners to
    +    // from yarnConf. It has to be executed on the NM node itself in order 
to resolve correctly.
    +    //
    --- End diff --
    
    nit: remove this line


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to