Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20327#discussion_r173030832
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
    @@ -126,7 +126,11 @@ private[spark] abstract class WebUI(
       def bind(): Unit = {
         assert(serverInfo.isEmpty, s"Attempted to bind $className more than 
once!")
         try {
    -      val host = Option(conf.getenv("SPARK_LOCAL_IP")).getOrElse("0.0.0.0")
    +      val host = if (Utils.isClusterMode(conf)) {
    --- End diff --
    
    Is this change actually required by the rest of your changes? What is the 
advantage of binding the UI to a specific host instead of "0.0.0.0"?
    
    Leaving it as is would also avoid adding `isClusterMode`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to