Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20750#discussion_r173132540
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeRowWriter.java
---
@@ -93,6 +93,26 @@ public void setNullAt(int ordinal) {
Platform.putLong(holder.buffer, getFieldOffset(ordinal), 0L);
}
+ @Override
+ public void setNullByte(int ordinal) {
--- End diff --
I see, but I am not sure about having only some of these methods here. I
mean, in `UnsafeArrayData` we have also `setNullDouble`, `setNullFloat`, etc.
etc. It seems a bit weird to me that some of them are set at the parent level
and some other no. It's not a big deal but I'd prefer for consistency to have
all of them. What do you think?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
