Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20750#discussion_r173142004
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeRowWriter.java
---
@@ -93,6 +93,26 @@ public void setNullAt(int ordinal) {
Platform.putLong(holder.buffer, getFieldOffset(ordinal), 0L);
}
+ @Override
+ public void setNullByte(int ordinal) {
--- End diff --
I am not sure it is a good idea, because then everyone while writing code
should know exactly how many bytes each type is. I prefer the current approach.
I would rather either reintroduce the `setNullAt` method with a match in the
`UnsafeArrayData`'s implementation or let is as it is now.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
