Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/20750#discussion_r173146007
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeRowWriter.java
---
@@ -93,6 +93,26 @@ public void setNullAt(int ordinal) {
Platform.putLong(holder.buffer, getFieldOffset(ordinal), 0L);
}
+ @Override
+ public void setNullByte(int ordinal) {
--- End diff --
This is pretty low level stuff, so you should know how many bytes things
contain at this point. I'd rather leave as it is. Doing a type match on such a
hot code path doesn't seem like a good idea.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
