Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20701#discussion_r173550800
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/clustering/BisectingKMeansSuite.scala 
---
    @@ -127,6 +128,7 @@ class BisectingKMeansSuite
         assert(clusterSizes.length === k)
         assert(clusterSizes.sum === numRows)
         assert(clusterSizes.forall(_ >= 0))
    +    assert(summary.numIter == 2)
    --- End diff --
    
    Would be nice to see a test where its not maxIter value being copied over


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to