Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20701#discussion_r173618874
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/clustering/KMeansModel.scala ---
    @@ -46,6 +47,10 @@ class KMeansModel @Since("2.4.0") (@Since("1.0.0") val 
clusterCenters: Array[Vec
       private val clusterCentersWithNorm =
         if (clusterCenters == null) null else clusterCenters.map(new 
VectorWithNorm(_))
     
    +  @Since("2.4.0")
    +  def this(clusterCenters: Array[Vector], distanceMeasure: String) =
    +    this(clusterCenters: Array[Vector], distanceMeasure, -1)
    --- End diff --
    
    yes, this can happen for instance when reloading a persisted model. 
Moreover this is only for the mllib model, which as far as I know is suggested 
not to be used anymore in favor of the new ml api. Any concern/suggestion about 
this?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to