Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/19222#discussion_r177694735
--- Diff:
sql/core/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java
---
@@ -377,9 +378,10 @@ final UTF8String getUTF8String(int rowId) {
if (stringResult.isSet == 0) {
return null;
} else {
- return UTF8String.fromAddress(null,
- stringResult.buffer.memoryAddress() + stringResult.start,
- stringResult.end - stringResult.start);
+ int size = stringResult.end - stringResult.start;
+ OffHeapMemoryBlock mb = new OffHeapMemoryBlock(
+ stringResult.buffer.memoryAddress() + stringResult.start, size);
+ return new UTF8String(mb);
--- End diff --
we can follow the previous code style:
```
new UTF8String(new OffHeapMemoryBlock(
stringResult.buffer.memoryAddress() + stringResult.start,
stringResult.end - stringResult.start
))
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
