Github user Ngone51 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20977#discussion_r179338562
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala ---
@@ -166,7 +166,7 @@ private class AsyncEventQueue(val name: String, conf:
SparkConf, metrics: LiveLi
val prevLastReportTimestamp = lastReportTimestamp
lastReportTimestamp = System.currentTimeMillis()
val previous = new java.util.Date(prevLastReportTimestamp)
- logWarning(s"Dropped $droppedEvents events from $name since
$previous.")
+ logWarning(s"Dropped $droppedCount events from $name since
$previous.")
--- End diff --
I think the change is OK, since it tells us how many events dropped during
the period `[System.currentTimeMillis(), lastReportTimestamp]`.
BTW, I still have the same question with `lastReportTimestamp `(though,
this is none of this pr's business):
When first time we log warning, `lastReportTimestamp ` should be `0` due to
the default value and without any initial. So, `previous` will be `1970/1/1
8:0:0 `. And, it means we got several dropped events since `1970/1/1 8:0:0 `.
I feel quite weird about it.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
