Github user phpisciuneri commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20977#discussion_r179481197
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala ---
    @@ -166,7 +166,7 @@ private class AsyncEventQueue(val name: String, conf: 
SparkConf, metrics: LiveLi
               val prevLastReportTimestamp = lastReportTimestamp
               lastReportTimestamp = System.currentTimeMillis()
               val previous = new java.util.Date(prevLastReportTimestamp)
    -          logWarning(s"Dropped $droppedEvents events from $name since 
$previous.")
    +          logWarning(s"Dropped $droppedCount events from $name since 
$previous.")
    --- End diff --
    
    Yeah that bothers me too!  Here is an example of that from the JIRA 
(boldness is mine):
    
    > 18/04/04 09:55:57 WARN AsyncEventQueue: Dropped 
com.codahale.metrics.Counter@3348dc4a events from eventLog **since Wed Dec 31 
18:00:00 CST 1969.**
    
    At the very least it could be the time that the `AsyncEventQueue` is 
instantiated.  Simple as changing 
[L57](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala#L57)?
    
    ```scala
    @volatile private var lastReportTimestamp = System.currentTimeMillis()
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to