Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20977#discussion_r179665313
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala ---
    @@ -166,7 +166,7 @@ private class AsyncEventQueue(val name: String, conf: 
SparkConf, metrics: LiveLi
               val prevLastReportTimestamp = lastReportTimestamp
               lastReportTimestamp = System.currentTimeMillis()
               val previous = new java.util.Date(prevLastReportTimestamp)
    -          logWarning(s"Dropped $droppedEvents events from $name since 
$previous.")
    +          logWarning(s"Dropped $droppedCount events from $name since 
$previous.")
    --- End diff --
    
    maybe the count should be a metrics, like 
https://github.com/phpisciuneri/spark/blob/3ad2f4298e290b3ce23533f04567bbd1fb096025/core/src/main/scala/org/apache/spark/scheduler/AsyncEventQueue.scala#L72?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to