Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/21080#discussion_r181931856
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala
---
@@ -575,7 +575,7 @@ class CodegenContext {
if (freshNameIds.contains(fullName)) {
val id = freshNameIds(fullName)
freshNameIds(fullName) = id + 1
- s"$fullName$id"
+ s"${fullName}_$id"
} else {
freshNameIds += fullName -> 1
fullName
--- End diff --
I'd suggest something like `s"${fullName}_0"` at L581. It also solves the
failed tests.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
